Skip to content

FDG-11737 Create Featured Content 'Historic Government Spending' page#2254

Merged
ntsim99 merged 7 commits into
masterfrom
FDG-11737
Jun 22, 2026
Merged

FDG-11737 Create Featured Content 'Historic Government Spending' page#2254
ntsim99 merged 7 commits into
masterfrom
FDG-11737

Conversation

@chasls2

@chasls2 chasls2 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket:

FDG-11737

The following are ALL required for the PR to be merged:

  • Provided testing instructions in JIRA ticket if applicable
  • Provided mocks or additional information in JIRA ticket if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome)
  • Verify all files are covered by at least 93% test coverage if applicable
  • Verify that dashes are used for any visible defaults of evergreen values if applicable
  • Check for code quality
    + Watch out for irrelevant changes
    + Take time to understand the logic and flow; be on guard for pitfalls
    + Look at handoff between components (esp. number of props)
    + Watch out for literals (vs. variables) for css specs if applicable

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Total Line Coverage: 93.53% ✅

@ntsim99 ntsim99 self-assigned this Jun 22, 2026
Comment thread src/layouts/featured-content/featured-content-helpers.js Outdated
Comment thread src/layouts/featured-content/featured-content-helpers.js Outdated
Comment thread src/layouts/featured-content/featured-content-helpers.js Outdated
Comment thread static/featured-content-images/gov_spend.png
Comment thread src/transform/featured-content-pages-config.js
Comment thread src/layouts/featured-content/featured-content-helpers.js

@ntsim99 ntsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this work. This sits well with me.

@ntsim99 ntsim99 merged commit 9614593 into master Jun 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants