Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the registration of IDbContextFactory<SyncLogDbContext> from the dependency injection container in the Entity Framework Core persistence setup.
- Removes the
AddDbContextFactory<SyncLogDbContext>service registration
Comments suppressed due to low confidence (1)
Syncerbell.EntityFrameworkCore/ServiceCollectionExtensions.cs:24
- Removing IDbContextFactory registration may break existing code that depends on it for creating DbContext instances in scenarios like background services or when multiple instances are needed. Consider documenting this breaking change or providing an alternative registration method if the factory is still needed.
services.AddDbContext<SyncLogDbContext>(options.ConfigureDbContextOptions);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.