fix: handle possible UnobservedTaskException#31
Merged
deleteLater merged 4 commits intomainfrom Mar 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent TaskScheduler.UnobservedTaskException noise/crashes by ensuring certain fire-and-forget tasks (notably WebSocket connection and keep-alive paths) have their exceptions observed/handled.
Changes:
- Added a
TaskExtensions.Forget()helper to safely observe exceptions from fire-and-forget tasks. - Updated
WebSocketDataSynchronizer.StartAsync()to observe the backgroundConnectAsync()task. - Wrapped
FbWebSocketkeep-alive ping send in a try/catch to avoid an unobserved exception when the connection is closed.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/FeatBit.ServerSdk/Utils/TaskExtensions.cs | Introduces TaskExtensions.Forget() for observing exceptions from fire-and-forget tasks. |
| src/FeatBit.ServerSdk/Transport/FbWebSocket.cs | Adds exception handling around keep-alive ping sending. |
| src/FeatBit.ServerSdk/DataSynchronizer/WebSocketDataSynchronizer.cs | Uses Forget() to observe the background connect task kicked off during start. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/FeatBit.ServerSdk/DataSynchronizer/WebSocketDataSynchronizer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #30