refactor: should not log reconnect error when stopped by caller#29
Merged
deleteLater merged 7 commits intomainfrom Aug 11, 2025
Merged
Conversation
deleteLater
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FbWebSocket's error handling to avoid logging reconnect errors when the WebSocket is stopped by the caller, addressing issue #28. The key changes include adding a message parameter to distinguish between error-related and caller-initiated shutdowns, and adjusting log levels to reduce noise.
- Added a
closeMessageparameter to theOnClosedevent handler to separate error information from shutdown messages - Modified the
CompleteClosemethod to accept an optional message parameter for non-error shutdowns - Changed log levels from Warning to Debug for caller-initiated shutdown scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/FeatBit.ServerSdk/Transport/FbWebSocket.cs | Updated OnClosed event signature and CompleteClose method to handle messages separately from exceptions |
| src/FeatBit.ServerSdk/Transport/FbWebSocket.Log.cs | Changed log levels from Warning to Debug for caller-initiated shutdowns and updated log messages |
| src/FeatBit.ServerSdk/DataSynchronizer/WebSocketDataSynchronizer.cs | Updated OnClosed event handler signature to match new parameter structure |
| tests/FeatBit.ServerSdk.Tests/Transport/FbWebSocketTests.cs | Updated test cases to verify the new closeMessage parameter in OnClosed events |
| tests/FeatBit.ServerSdk.Tests/FbClientOfflineTests.cs | Fixed test configuration from Offline(false) to Offline(true) |
deleteLater
deleted the
refactor/should-not-log-error-when-stopped-by-caller
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #28