feat: Add SingleStore online store support for feature view versioning#6195
Open
antznette1 wants to merge 1 commit intofeast-dev:masterfrom
Open
feat: Add SingleStore online store support for feature view versioning#6195antznette1 wants to merge 1 commit intofeast-dev:masterfrom
antznette1 wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
antznette1
requested review from
ejscribner,
franciscojavierarceo and
shuchu
and removed request for
a team
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+276
to
+279
| if isinstance(self, (SqliteOnlineStore, SingleStoreOnlineStore)): | ||
| continue | ||
|
|
||
| raise VersionedOnlineReadNotSupported(self.__class__.__name__, version_tag) |
Contributor
There was a problem hiding this comment.
🟡 Stale error message in VersionedOnlineReadNotSupported excludes SingleStore from supported stores
The VersionedOnlineReadNotSupported error at sdk/python/feast/errors.py:144-145 says "Currently only SQLite supports version-qualified feature references" but this PR adds SingleStore as a supported store in _check_versioned_read_support at line 276. Users of other online stores (e.g., Redis, DynamoDB) who attempt versioned reads will see an error message that fails to mention SingleStore as a supported option, which is misleading.
Prompt for agents
Update the VersionedOnlineReadNotSupported error class in sdk/python/feast/errors.py at lines 141-146. The error message currently says 'Currently only SQLite supports version-qualified feature references.' but it should be updated to also mention SingleStore, e.g., 'Currently only SQLite and SingleStore support version-qualified feature references.' since SingleStore was added as a supported store in the _check_versioned_read_support method.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds online feature view versioning support for the SingleStore online store when
registry.enable_online_feature_view_versioningis enabled.It updates SingleStore’s table routing to read/write from versioned namespaces (e.g.
{project}_{feature_view}_v{N}) so version-qualified refs likedriver_stats@v1:avg_daily_tripscan be served from the correct underlying online table. It also updates the global online-store guard to allow version-qualified reads for SingleStore (and still reject unsupported stores) when versioning is enabled.Additionally, it adds an integration/universal test covering SingleStore version-qualified reads.
Which issue(s) this PR fixes:
Fixes #6181
Checks
git commit -s)Testing Strategy
Misc
Notes:
registry.enable_online_feature_view_versioningis enabled; otherwiseVersionedOnlineReadNotSupportedis raised.