Skip to content

feat: Batch_engine config injection in feature_store.yaml through operator#5938

Open
aniketpalu wants to merge 3 commits intofeast-dev:masterfrom
aniketpalu:RHOAIENG-41630
Open

feat: Batch_engine config injection in feature_store.yaml through operator#5938
aniketpalu wants to merge 3 commits intofeast-dev:masterfrom
aniketpalu:RHOAIENG-41630

Conversation

@aniketpalu
Copy link
Contributor

@aniketpalu aniketpalu commented Feb 3, 2026

What this PR does / why we need it:

Adds support for batch_engine configuration in the Feast Operator, allowing users to configure compute engines (Spark, Ray, etc.) via ConfigMap reference in the FeatureStore CR.

Usage

1. Create a ConfigMap with batch engine config

apiVersion: v1
kind: ConfigMap
metadata:
  name: ray-batch-engine-config
data:
  config: |
    type: ray.engine
    max_workers: 4
    enable_optimization: true

2. Reference it in FeatureStore CR

apiVersion: feast.dev/v1
kind: FeatureStore
metadata:
  name: my-feature-store
spec:
  feastProject: my_project
  batchEngine:
    configMapRef:
      name: ray-batch-engine-config
    configMapKey: config  # optional, defaults to "config"

3. Generated feature_store.yaml output

project: my_project
batch_engine:
  type: ray.engine
  max_workers: 4
  enable_optimization: true

Important Considereations

  • Only api/v1 modified (not v1alpha1)
  • ConfigMap used instead of Secret (engine configs typically don't contain credentials)
  • configMapKey defaults to "config" if not specified
  • type field required in ConfigMap data

Which issue(s) this PR fixes:

Misc


Open with Devin

…rator

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu aniketpalu requested a review from a team as a code owner February 3, 2026 11:40
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View issue and 5 additional flags in Devin Review.

Open in Devin Review

Comment on lines +7 to +8
newName: quay.io/aniket-redhat/feast-operator
newTag: dev0.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Development image registry left in production kustomization.yaml

The kustomization.yaml file was changed to point to a personal development registry instead of the official Feast registry.

Click to expand

Issue

The image configuration in infra/feast-operator/config/manager/kustomization.yaml was changed from the official registry to a personal development registry:

Before (correct):

images:
- name: controller
  newName: quay.io/feastdev/feast-operator
  newTag: 0.59.0

After (incorrect):

images:
- name: controller
  newName: quay.io/aniket-redhat/feast-operator
  newTag: dev0.8

Impact

If this change is merged and deployed:

  1. Production deployments would pull from a personal development registry (quay.io/aniket-redhat/feast-operator)
  2. The image tag dev0.8 suggests an unstable development build
  3. This could cause security concerns (untrusted image source) and reliability issues (development images may not be stable)
  4. The image may not even be publicly accessible, causing deployment failures

Recommendation: Revert the image configuration to use the official Feast registry: newName: quay.io/feastdev/feast-operator and newTag: 0.59.0

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aniketpalu this ^

@ntkathole ntkathole changed the title feat: batch_engine config injection in feature_store.yaml through operator feat: Batch_engine config injection in feature_store.yaml through operator Feb 4, 2026
…g func

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants