feat: Batch_engine config injection in feature_store.yaml through operator#5938
Open
aniketpalu wants to merge 3 commits intofeast-dev:masterfrom
Open
feat: Batch_engine config injection in feature_store.yaml through operator#5938aniketpalu wants to merge 3 commits intofeast-dev:masterfrom
aniketpalu wants to merge 3 commits intofeast-dev:masterfrom
Conversation
…rator Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
Comment on lines
+7
to
+8
| newName: quay.io/aniket-redhat/feast-operator | ||
| newTag: dev0.8 |
Contributor
There was a problem hiding this comment.
🔴 Development image registry left in production kustomization.yaml
The kustomization.yaml file was changed to point to a personal development registry instead of the official Feast registry.
Click to expand
Issue
The image configuration in infra/feast-operator/config/manager/kustomization.yaml was changed from the official registry to a personal development registry:
Before (correct):
images:
- name: controller
newName: quay.io/feastdev/feast-operator
newTag: 0.59.0After (incorrect):
images:
- name: controller
newName: quay.io/aniket-redhat/feast-operator
newTag: dev0.8Impact
If this change is merged and deployed:
- Production deployments would pull from a personal development registry (
quay.io/aniket-redhat/feast-operator) - The image tag
dev0.8suggests an unstable development build - This could cause security concerns (untrusted image source) and reliability issues (development images may not be stable)
- The image may not even be publicly accessible, causing deployment failures
Recommendation: Revert the image configuration to use the official Feast registry: newName: quay.io/feastdev/feast-operator and newTag: 0.59.0
Was this helpful? React with 👍 or 👎 to provide feedback.
…g func Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for batch_engine configuration in the Feast Operator, allowing users to configure compute engines (Spark, Ray, etc.) via ConfigMap reference in the FeatureStore CR.
Usage
1. Create a ConfigMap with batch engine config
2. Reference it in FeatureStore CR
3. Generated
feature_store.yamloutputImportant Considereations
Which issue(s) this PR fixes:
Misc