Skip to content

Devin/1769551745 update snowflake requirements#5917

Open
franciscojavierarceo wants to merge 16 commits intofeast-dev:masterfrom
franciscojavierarceo:devin/1769551745-update-snowflake-requirements
Open

Devin/1769551745 update snowflake requirements#5917
franciscojavierarceo wants to merge 16 commits intofeast-dev:masterfrom
franciscojavierarceo:devin/1769551745-update-snowflake-requirements

Conversation

@franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented Jan 28, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc


Open with Devin

@franciscojavierarceo franciscojavierarceo requested a review from a team as a code owner January 28, 2026 01:32
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View issues and 7 additional flags in Devin Review.

Open in Devin Review

Comment on lines 901 to +907
# wrapt
# yarl
# zipp
setuptools==80.9.0 \
--hash=sha256:062d34222ad13e0cc312a4c02d73f059e86a4acbfbdea8f8f76b28c99f306922 \
--hash=sha256:f36b47402ecde768dbfafc46e8e4207b4360c654f1f3bb84475f0a28628fb19c
# via httptools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Conflicting duplicate setuptools pins in py3.10 minimal sdist build requirements

The generated build requirements file pins two different versions of setuptools, which will cause pip’s resolver to fail (it cannot satisfy setuptools==80.10.2 and setuptools==80.9.0 simultaneously).

Actual: installing from this requirements file can error with an unsatisfiable constraint.
Expected: setuptools should be pinned once, or the extra dependency (httptools) should be resolved without adding a second setuptools pin.

Where it happens

At the bottom of the file:

  • setuptools==80.10.2 is listed as an “unsafe” package
  • then setuptools==80.9.0 is listed again ("# via httptools")

See sdk/python/requirements/py3.10-minimal-sdist-requirements-build.txt:823-907.

(Refers to lines 823-907)

Recommendation: Remove the second setuptools==80.9.0 entry (or otherwise ensure only one version is pinned). If httptools requires build tooling, add/pin httptools (and let it depend on setuptools) rather than pinning a second setuptools version.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines 915 to +921
# wrapt
# yarl
# zipp
setuptools==80.9.0 \
--hash=sha256:062d34222ad13e0cc312a4c02d73f059e86a4acbfbdea8f8f76b28c99f306922 \
--hash=sha256:f36b47402ecde768dbfafc46e8e4207b4360c654f1f3bb84475f0a28628fb19c
# via httptools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Conflicting duplicate setuptools pins in py3.11 minimal sdist build requirements

The generated build requirements file pins two different versions of setuptools (80.10.2 and 80.9.0), which will cause dependency resolution to fail.

Where it happens

See the file tail in sdk/python/requirements/py3.11-minimal-sdist-requirements-build.txt:837-921.

(Refers to lines 837-921)

Recommendation: Ensure setuptools is pinned only once in this lock/requirements output (remove the extra setuptools==80.9.0 entry).

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines 902 to +908
# websockets
# wrapt
# yarl
setuptools==80.9.0 \
--hash=sha256:062d34222ad13e0cc312a4c02d73f059e86a4acbfbdea8f8f76b28c99f306922 \
--hash=sha256:f36b47402ecde768dbfafc46e8e4207b4360c654f1f3bb84475f0a28628fb19c
# via httptools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Conflicting duplicate setuptools pins in py3.12 minimal sdist build requirements

The generated build requirements file pins two different versions of setuptools (80.10.2 and 80.9.0). This makes the requirements set unsatisfiable.

Where it happens

See sdk/python/requirements/py3.12-minimal-sdist-requirements-build.txt:827-908.

(Refers to lines 827-908)

Recommendation: Remove the duplicate/older setuptools==80.9.0 pin so only a single version is required.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant