chore(deps): Bump virtualenv from 20.23.0 to 20.36.1 in /sdk/python/requirements#5848
Conversation
a95c6b5 to
732aab3
Compare
8966b78 to
db29829
Compare
| virtualenv==20.36.1 \ | ||
| --hash=sha256:575a8d6b124ef88f6f51d56d656132389f961062a9177016a50e4f507bbcc19f \ | ||
| --hash=sha256:8befb5c81842c641f8ee658481e42641c68b5eab3521d8e092d18320902466ba |
There was a problem hiding this comment.
🔴 Version constraint mismatch: requirements files updated to virtualenv 20.36.1 but setup.py/pyproject.toml still constrain to <20.24.2
The PR updates virtualenv to version 20.36.1 in the CI requirements files, but the setup.py and pyproject.toml files still have conflicting version constraints that would prevent this version from being installed.
Click to expand
Conflicting constraints in setup.py and pyproject.toml
Both setup.py:201 and pyproject.toml:139 pin:
"virtualenv==20.23.0",And both setup.py:242 and pyproject.toml:182 have an upper bound:
"virtualenv<20.24.2",Impact
The updated version 20.36.1 violates both constraints:
- It is not equal to
20.23.0 - It is greater than
20.24.2
This creates an inconsistency where:
- Installing via
pip install feast[ci]would use the constraints from setup.py/pyproject.toml (getting 20.23.0) - Installing via the requirements files directly would get 20.36.1
This could lead to:
- CI failures if the requirements files are regenerated from setup.py
- Inconsistent behavior between different installation methods
- The security fixes in virtualenv 20.36.1 (TOCTOU vulnerabilities) not being applied when installing via setup.py
Recommendation
The setup.py and pyproject.toml files should also be updated to allow virtualenv 20.36.1, for example by changing the constraints to virtualenv>=20.36.1,<21 or simply virtualenv==20.36.1.
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.23.0 to 20.36.1. - [Release notes](https://github.com/pypa/virtualenv/releases) - [Changelog](https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst) - [Commits](pypa/virtualenv@20.23.0...20.36.1) --- updated-dependencies: - dependency-name: virtualenv dependency-version: 20.36.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
db29829 to
c59d868
Compare
Bumps virtualenv from 20.23.0 to 20.36.1.
Release notes
Sourced from virtualenv's releases.
... (truncated)
Changelog
Sourced from virtualenv's changelog.
... (truncated)
Commits
d0ad11drelease 20.36.1dec4cecMerge pull request #3013 from gaborbernat/fix-sec5fe5d38release 20.36.0 (#3011)9719376release 20.36.00276db6Add support for PEP 440 version specifiers in the--pythonflag. (#3008)4f900c2Fix Interpreter discovery bug wrt. Microsoft Store shortcut using Latin-1 (#3...13afcc6fix: resolve EncodingWarning in tox upgrade environment (#3007)31b5d31[pre-commit.ci] pre-commit autoupdate (#2997)7c28422fix: update filelock dependency version to 3.20.1 to fix CVE CVE-2025-68146 (...365628ctest_too_many_open_files: assert onerrno.EMFILEinstead ofstrerror(#3001)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.