MustHaveMinimumLength for immutable array #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the MustHaveMinimumLength assertion for ImmutableArray<T> to avoid boxing that would occur with generic IEnumerable<T> extensions. The implementation includes proper handling of default immutable array instances and follows the existing library patterns.
- Adds exception factory method for minimum length violations with appropriate error messages
- Implements two extension method overloads following the library's standard pattern (default exception and custom exception factory)
- Includes comprehensive test coverage for all scenarios including edge cases with default instances
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| issue-121-must-have-minimum-length-for-immutable-array.md | Planning document outlining implementation requirements |
| Throw.InvalidMinimumImmutableArrayLength.cs | Exception factory method for minimum length validation errors |
| Check.MustHaveMinimumLength.cs | Extension methods implementing the minimum length assertion |
| MustHaveMinimumLengthTests.cs | Comprehensive test suite covering all scenarios and edge cases |
Code/Light.GuardClauses/ExceptionFactory/Throw.InvalidMinimumImmutableArrayLength.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
Production Code
Throw.InvalidMinimumImmutableArrayLength.cs
Exception factory method that creates appropriate error messages for minimum length violations, handling both regular and default ImmutableArray instances.
Check.MustHaveMinimumLength.cs
Two extension method overloads:
Both methods use parameter.IsDefault check to safely handle default instances (treats as length 0).