Add initial PCP support#15
Closed
sashahilton00 wants to merge 1 commit into
Closed
Conversation
Author
|
PR moved to libp2p#17 since this appears to be unmaintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't ready to merge yet, as some of the logic for a correct implementation is missing upstream, but I would be grateful if someone with a router that supports PCP could test this and let me know if it is working as expected (ie. it creates a mapping).
There is also potential for a bigger rework of go-nat in general, as the architecture of PCP is quite different from previous NAT traversal implementations, as it takes into account multiple network interfaces, supports IPv4 and IPv6, and server sent events.
Once merged, this should close #3