Open
Conversation
src/.env
Outdated
| @@ -0,0 +1 @@ | |||
| REACT_APP_FIREBASE_KEY=AIzaSyCkKPnWO88ZHGUaazFntf_e4uuf2xIPBmQ No newline at end of file | |||
Contributor
There was a problem hiding this comment.
don't commit the env file
src/containers/SignIn/SignIn.tsx
Outdated
Comment on lines
27
to
36
| const characters = | ||
| "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; | ||
|
|
||
| let result = ""; | ||
|
|
||
| for (let i = 0; i < 8; i++) { | ||
| const randomIndex = Math.floor(Math.random() * characters.length); | ||
| result += characters.charAt(randomIndex); | ||
| } | ||
| setRandomString(result); | ||
|
|
Contributor
There was a problem hiding this comment.
use a random name generator. store some names in an array and pick a random one from there
Comment on lines
+7
to
+11
| authDomain: "dear-diary-emailusername-5f60d.firebaseapp.com", | ||
| projectId: "dear-diary-emailusername-5f60d", | ||
| storageBucket: "dear-diary-emailusername-5f60d.appspot.com", | ||
| messagingSenderId: "71014166140", | ||
| appId: "1:71014166140:web:fbe2e46b2a929925ed23f9" |
Contributor
There was a problem hiding this comment.
store all of these values in the env file
src/redux/reducers/userReducer.ts
Outdated
|
|
||
| export const { addUser, setUsers } = userSlice.actions; | ||
|
|
||
| export const fetchUsers = () => async (dispatch: any) => { |
Contributor
There was a problem hiding this comment.
use saga to call APIs don't directly call them inside UI or inside the slice
shamal-iroshan
suggested changes
Dec 19, 2023
Contributor
shamal-iroshan
left a comment
shamal-iroshan
left a comment
There was a problem hiding this comment.
fix commented things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.