-
Notifications
You must be signed in to change notification settings - Fork 4
Re-enable builds on github action using arch linux container environment #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
681d255 to
c5b6588
Compare
eb9ac4b to
c1cb2e6
Compare
c1cb2e6 to
852034f
Compare
004ec7e to
3027da2
Compare
3027da2 to
cc42f94
Compare
|
Current issue: library path problem On Archlinux and most fcitx5 development environment (= the new build env) -> uses source builds and saves RPATH on build, so they can find the shared libraries. On deb file I'm making -> I want to make it able to use with latest Ubuntu at least as large portion of JP Linux users use that distribution. They expect fcitx5 libraries to be under CSKK -> The deb file on release places the libcskk under For these mixed up pathes especially the RPATH stored on the build time, the library search paths are mixed up and not easy to confirm what library is actually missing or just unable to find from the search paths or accidentally finding the old version. Storing RPATH on build was an easy fix for using non-system library like CSKK but it causes more trouble when we want to run on multiple environments and expecting different build environment and runtime environment. We probably need to disable storing RPATH and find a better solution for locally built libraries. |
|
Even if I fix the library resolution PATHs, making a good deb file for Ubuntu24 seems hard because fcitx5 have changed the ABI and now we are building against latest fcitx5 which uses FCITX_ADDON_FACTORY_V2, but the Ubuntu's fcitx5 package only accepts FCITX_ADDON_FACTORY version. |
you can still use FCITX_ADDON_FACTORY, that's no problem. If you want , you could do ifdef check to prefer FCITX_ADDON_FACTORY_V2 where possible |
Suggested fix on the last comment of #83
TODO: Need to review and confirm the release file actually works before merging. Run with workflow_dispatch event and fix the release file not to be attatched to the release but to be downloadable on manual run