Update modbus spec with new params and examples#1312
Conversation
Added FLOAT32 example to type examples, added a 'bit' interpretation parameter, and added 'ASCII' to the protocol examples list as requested. Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ples Updated 'i.e.,' to 'e.g.,' for 'type' and 'scale', and added a specific example for the 'bit' integer bit index interpretation parameter as requested. Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
Updated ModbusFamilyProvider.java to allow the new `bit` interpretation parameter as it was added to the modbus.md spec. Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
- Added FLOAT32 - Added bit parameter - Added ASCII protocol - Updated "i.e." to "e.g." for examples Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
- Added FLOAT32 - Added bit parameter - Added ASCII protocol - Updated "i.e." to "e.g." for examples Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>
1 participant
Update the
modbus.mdspec with the following items:bitinterpretation parameter (integer bit index)ASCIIvalue for the protocol enumPR created automatically by Jules for task 5253742198133533737 started by @grafnu