Add error catch to the _handleSmsStatusReport function, fixes #56 #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraffJosh
changed the title
Author
|
Fixes #56 (I'm unsure how to link this to that issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message handler sometimes errors for a reason I'm not familiar with:
I add a try block to the line to let it fail more gracefully. I've implemented this on my instance and it has resolved the issue and allowed for reliable operation of the repository.
Tested on BananaPiR3-mini with Quecetel EC25G on T-Mobile.
This is my first open-source PR, I am open to suggestions and corrections.