Apply cargo clippy fixes and format with dprint#4440
Open
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Open
Apply cargo clippy fixes and format with dprint#4440devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
- Auto-fixed clippy suggestions via cargo clippy --fix - Manually fixed collapsible_if in listener/recorder.rs - Removed unused import tauri::Manager in desktop/lib.rs - Excluded plugins/cli2 from workspace (missing Cargo.toml) - Ran cargo fmt to ensure consistent formatting Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply cargo clippy fixes and dprint formatting
Summary
Ran
cargo clippy --fixfollowed bycargo clippyand manually applied remaining suggestions. Then resolved merge conflicts with main and applieddprint fmtto fix import ordering for CI compliance.Changes by category:
.to_string(), simplified nestedifstatements to use let-chains (if let ... && let ...), removed unnecessary lifetime annotations, improved tuple field access spacing (e.g.,device.0 .0instead ofdevice.0.0to disambiguate from float literals)tauri::Managerimport inapps/desktop/src-tauri/src/lib.rsplugins/cli2to workspace exclusions (directory lacks aCargo.toml)All changes are linting/formatting improvements with no functional changes intended.
Updates Since Last Revision
dprint fmtto ensure import ordering meets CI requirements (alphabetical/conventional ordering per rustfmt rules)Review & Testing Checklist for Human
v1_0_2_nightly_14_extract_from_sqlite.rs,v1_0_2_nightly_1_from_v0.rs,version/macro.rs,recorder.rs), nestedif letstatements were collapsed into let-chains. Confirm the logic is equivalentdevice.0 .0(with space) disambiguate from float literals - verify this doesn't affect behaviorplugins/cli2exclusion: This directory has noCargo.toml(onlynode_modules). Verify this exclusion is intentionalTest Plan
Run
cargo clippyin the workspace to confirm zero warnings remain. Rundprint checkto verify formatting compliance.Notes
if let ... && let ...) requires Rust 1.53+. Project uses 1.94.0 so this is safe.fmt(dprint) anddesktop_ci(cargo check/test), confirming both formatting and compilation