Fix mic detection exclusions for coding and dictation apps#4419
Open
ComputelessComputer wants to merge 2 commits intomainfrom
Open
Fix mic detection exclusions for coding and dictation apps#4419ComputelessComputer wants to merge 2 commits intomainfrom
ComputelessComputer wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Add applyInitialSettingsSideEffects function to apply persisted settings on app startup. This ensures settings like DND respect and ignored platforms are properly loaded when the app starts. Improve app bundle ID matching by adding case-insensitive comparison and trimming whitespace in bundleIdToName and nameToBundleId functions. This provides more robust app identification for notification filtering.
ComputelessComputer
force-pushed
the
feat-initial-settings-app-matching
branch
from
756377e to
6d37dda
Compare
ComputelessComputer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes noisy mic-detection notifications caused by coding agents and dictation tools, and it also fixes manual exclusions not being applied reliably.
Changes:
Validation:
pnpm -F @hypr/desktop typecheckpnpm -F @hypr/desktop test -- --run apps/desktop/src/store/tinybase/store/settings.test.ts