Skip to content

Preserve CJK IME typing#5924

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/cjk-ime-typing
Jul 6, 2026
Merged

Preserve CJK IME typing#5924
ComputelessComputer merged 1 commit into
mainfrom
fix/cjk-ime-typing

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Skip title navigation while composition is active and protect rich-editor content sync around IME composition.


Note

Medium Risk
Touches focused-session title navigation and ProseMirror content replacement timing; wrong composition detection could delay sync or leave stale content, but scope is narrow and covered by new tests.

Overview
Fixes CJK/IME typing being interrupted when composition keys (e.g. Enter with keyCode 229) were treated as title navigation or when external note content sync ran mid-composition.

Session title: TitleInput now bails out of handleKeyDown during composition (isComposing, Process, keyCode 229), so confirming IME text no longer commits the title or jumps to the editor.

Note editor: Adds composition tracking via a ProseMirror plugin, getEditorCompositionWaitMs (500ms active + post-composition grace), and deferred syncContent retries so reconciledInitialContent updates do not replace the document while IME is active or immediately after it ends. Composition state resets on view dispose. Unit tests cover title IME Enter and the wait-window helper.

Reviewed by Cursor Bugbot for commit 39cbe4d. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Jul 6, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 39cbe4d
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a4b4afa5ac2be0008f812dd

Comment thread packages/editor/src/note/index.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9fb5095. Configure here.

Comment thread packages/editor/src/note/index.tsx
Skip title navigation while composition is active and protect rich-editor content sync around IME composition.
@ComputelessComputer ComputelessComputer merged commit 7b4eb00 into main Jul 6, 2026
21 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/cjk-ime-typing branch July 6, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant