Preserve CJK IME typing#5924
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
5ee06b4 to
9fb5095
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9fb5095. Configure here.
Skip title navigation while composition is active and protect rich-editor content sync around IME composition.
9fb5095 to
39cbe4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Skip title navigation while composition is active and protect rich-editor content sync around IME composition.
Note
Medium Risk
Touches focused-session title navigation and ProseMirror content replacement timing; wrong composition detection could delay sync or leave stale content, but scope is narrow and covered by new tests.
Overview
Fixes CJK/IME typing being interrupted when composition keys (e.g. Enter with
keyCode229) were treated as title navigation or when external note content sync ran mid-composition.Session title:
TitleInputnow bails out ofhandleKeyDownduring composition (isComposing,Process,keyCode229), so confirming IME text no longer commits the title or jumps to the editor.Note editor: Adds composition tracking via a ProseMirror plugin,
getEditorCompositionWaitMs(500ms active + post-composition grace), and deferredsyncContentretries soreconciledInitialContentupdates do not replace the document while IME is active or immediately after it ends. Composition state resets on view dispose. Unit tests cover title IME Enter and the wait-window helper.Reviewed by Cursor Bugbot for commit 39cbe4d. Bugbot is set up for automated code reviews on this repo. Configure here.