Replace transcript scroll chips with side controls#5882
Open
ComputelessComputer wants to merge 5 commits into
Open
Replace transcript scroll chips with side controls#5882ComputelessComputer wants to merge 5 commits into
ComputelessComputer wants to merge 5 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d925973. Configure here.
Allows transcript top and bottom scroll chips to render for inactive sessions while preserving live-only auto-scroll behavior. Adds regression coverage for both chip directions.
Keep the transcript scroll chip raised whenever the collapsed chat CTA is present so it does not jump away during hover.
ComputelessComputer
force-pushed
the
fix/inactive-transcript-scroll-chips
branch
from
0545889 to
3fe0ce3
Compare
Use right-side scroll controls with disabled states and update renderer coverage for the new interaction.
ComputelessComputer
force-pushed
the
fix/transcript-bottom-chip-hover
branch
from
d925973 to
29012e9
Compare
ComputelessComputer
changed the base branch from
fix/inactive-transcript-scroll-chips
to
main
Expose a canScroll signal from the transcript viewport hook and keep the side controls visible when content overflows inside the top and bottom proximity thresholds.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
This is part 2 of 2 in a stack made with GitButler:
Note
Low Risk
UI-only transcript scroll UX in the desktop session view; auto-scroll logic is largely unchanged aside from richer overflow detection.
Overview
Replaces the transcript’s contextual Go to top / Go to bottom center chips with a right-side vertical control (up/down icon buttons) shown whenever the viewport has overflow (
canScroll).Each button is disabled at the corresponding edge (
isAtTop/isAtBottom). Controls stay visible when floating chat is expanded;useShell/ chat-mode gating and the globals.css rule that nudged chip position near the floating chat CTA are removed.useScrollDetectionnow exposescanScroll, treats non-scrollable content as at both edges, and refreshes state on ResizeObserver and MutationObserver (not only scroll). Tests are updated for the new labels, layout, and behavior.Reviewed by Cursor Bugbot for commit 56b5833. Bugbot is set up for automated code reviews on this repo. Configure here.