Suppress cross-channel transcript echo#5880
Open
ComputelessComputer wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for old-char canceled.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 19c913f. Configure here.
Add phrase-based live transcript echo suppression across mic and speaker channels, including partial and held-tail handling.
Use newly detected duplicate runs as local tail state so interrupted cross-channel echoes stay suppressed across final and partial transcript updates.
19c913f to
eb044c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add phrase-based live transcript echo suppression across mic and speaker channels, including partial and held-tail handling.
Note
Medium Risk
Changes real-time transcript output in the listener path; wrong heuristics could drop legitimate simultaneous speech, though tests and distinct-text cases mitigate that.
Overview
Adds cross-channel echo suppression in
LiveTranscriptEngineso mic/speaker bleed does not duplicate the live transcript.After normalization and
TranscriptProcessor, a newCrossChannelEchoSuppressorfiltersnew_wordsandpartialsby matching normalized tokens on different channels within a time window (≥3-token runs), plus echo-tail chaining for words that continue a recently suppressed duplicate. Kept finals extend rolling history (30s prune); distinct overlapping speech on another channel is left alone.processandflushboth run the suppressor and skip emitting an update when the delta is empty and there is no segment change. Unit tests cover final/partial echo, tail chaining after interrupted runs, and non-echo cross-channel text.Reviewed by Cursor Bugbot for commit eb044c2. Bugbot is set up for automated code reviews on this repo. Configure here.