add VariantType::Type to replace direct use of QMetaType::Type#48321
Open
add VariantType::Type to replace direct use of QMetaType::Type#48321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48320 mentions that working with variant types still involves
QMetaType. This PR introduces our own substitute enum, with values that are identical to those ofQMetaType, and updates the whole codebase to use it everywhere. This way, variant call sites don't have to referenceQMetaTypedirectly.The enum looks like this:
Since the values are the same, there should be no change in behavior.
Note that there is still some remaining direct usage of Qt's meta type system via the
Q_DECLARE_METATYPEmacro, which enables storing user-defined types inQVariant. We'll address that separately.