add variant type aliases, as preparation to migrate away from QVariant#48319
Merged
add variant type aliases, as preparation to migrate away from QVariant#48319
Conversation
clintjedwards
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our ongoing process of migrating away from Qt types, this PR is the first in a series for addressing
QVariant.The plan is to do something similar to what we're doing with the Cow types, by introducing a replacement type,
Variant, that behaves exactly the same way asQVariantand is initially a wrapper around it. Later, the implementation can be substituted with something else, likelystd::variant. Unlike the Cow types, however, which are being slowly rolled out throughout the project, forVariantthe plan will be to roll it out to the whole project in one shot via a type alias. The reason for doing it this way is to avoid deep copy conversions between ourVariantandQVariant, which are hard to avoid when the types are distinct and variants are nested within variants.Steps:
Variant*type aliases (this PR). Easy change, nothing using it yet.QVariant*in the whole project toVariant*. The actual types would still beQVariant*so this should be completely safe with no worry about behavioral changes.Variant*type aliases withVariant*classes that wrapQVariant*, forwarding to an inner instance. No change to the call sites.Variant*classes with something not Qt-based.