Update dependencies, remove Glob:glob and replace with node:fs/promises:glob. #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
reviewed
Nov 26, 2025
Member
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
could you run npm run lint:fix and commit the changes?
Author
|
Ran linter and committed changes, apologies for the delay! |
Author
|
I'm also noting that with one of the errors, specifically caused by the following test: test('dir list default options', async t => {
t.plan(1)
const options = {
root: path.join(__dirname, '/static'),
prefix: '/public',
list: true
}
const route = '/public/shallow'
const content = { dirs: ['empty'], files: ['sample.jpg'] }
await helper.arrange(t, options, async (url) => {
await t.test(route, async t => {
t.plan(3)
const response = await fetch(url + route)
t.assert.ok(response.ok)
t.assert.deepStrictEqual(response.status, 200)
t.assert.deepStrictEqual(await response.json(), content)
})
})
})Outputting test at test\dir-list.test.js:123:13
✖ /public/shallow (66.4565ms)
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
{
dirs: [
'empty'
],
files: [
+ 'no-link',
'sample.jpg'
]
}I note that the file, |
smartinio
reviewed
Dec 21, 2025
There was a problem hiding this comment.
Both fsPromises.glob and Array.fromAsync are documented as Node.js v22 features. CI still supports v20. Will this not break v20?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed
glob:globand replaced withnode/fs:glob. Code style has remained largely the same, however it seems there is still some test cases that are producing additional errors such as the following:This was decided via diffing the testcase output of the main branch and my PR. If I'm doing something stupid with the new version let me know and I'll fix it then resubmit.
This change will constrain releases to node >= 20, as node/fs:glob was added around then. I've included my testcase output below.