Allow click_type and parser with Union type annotations#1683
Open
anibali wants to merge 1 commit intofastapi:masterfrom
Open
Allow click_type and parser with Union type annotations#1683anibali wants to merge 1 commit intofastapi:masterfrom
click_type and parser with Union type annotations#1683anibali wants to merge 1 commit intofastapi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any parameter annotated with a Union type (e.g.
int | str) would unconditionally hit an assertion error. This change skips that assertion when the parameter has a customparserorclick_typespecified. In those cases Typer delegates parsing entirely to the caller, making the type annotation irrelevant for type resolution.This PR addresses #1595 (comment) and #1595 (comment), giving users the ability to use union types if they also specify how they should be parsed/converted.