Skip to content

✨ Add field-level db comments when a field description exists#1293

Draft
iloveitaly wants to merge 5 commits intofastapi:mainfrom
iloveitaly:db-comments
Draft

✨ Add field-level db comments when a field description exists#1293
iloveitaly wants to merge 5 commits intofastapi:mainfrom
iloveitaly:db-comments

Conversation

@iloveitaly
Copy link

This PR fixes #492 (comment) by adding column-level db comments
when a field description exists.

I can add some tests if this is the sort of PR that would be accepted.

I've implemented this in my SQLModel extension here: https://github.com/iloveitaly/activemodel/blob/master/activemodel/get_column_from_field_patch.py

Details:

  • feat: pull field descriptions into db comments
  • docs: document autostring
  • feat: add use_attribute_docstrings pydantic config for improved docstrings

@svlandeg svlandeg added the feature New feature or request label Feb 20, 2025
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution!

There are some linting errors and test failures - could you look into those? It will facilitate the review process if the CI is green. I'll go ahead and put this PR in draft in the meantime 🙏

@svlandeg svlandeg marked this pull request as draft February 20, 2025 10:42
@svlandeg svlandeg changed the title feat: add field-level db comments when a field description exists ✨ Add field-level db comments when a field description exists Feb 20, 2025
@iloveitaly
Copy link
Author

@svlandeg awesome, will work on CI and we can go from there! Is there anything else that I should work on in order to get this merged?

@svlandeg
Copy link
Member

@svlandeg awesome, will work on CI and we can go from there! Is there anything else that I should work on in order to get this merged?

A test case is always useful, as it helps the reviewer as well to quickly run a small example. And it'll likely be necessary anyway to get the test coverage back to 100% (ensuring that all code in the code base gets tested).

@iloveitaly
Copy link
Author

iloveitaly commented Feb 26, 2025

Awesome, I should have some time to help there. I have a bunch of other SQLModel improvements I'd love to pull over from activemodel, so understanding the best contribution flow would be really helpful

@svlandeg
Copy link
Member

Awesome, I should have some time to help there. I have a bunch of other SQLModel improvements I'd love to pull over from activemodel, so understanding the best contribution flow would be really helpful

Sure thing, let me know if you have specific questions/doubts about contributing to sqlmodel, happy to provide guidance if needed!

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the conflicts Automatically generated when a PR has a merge conflict label Dec 26, 2025
@morigs
Copy link

morigs commented Jan 22, 2026

Hi, looking forward to this feature. Do you have plans on finishing it?

@github-actions
Copy link
Contributor

Heads-up: this will be closed in 3 days unless there's new activity.

@iloveitaly
Copy link
Author

Friendly reminder about this pull request! Let me know if there are any further updates needed.

@github-actions github-actions bot removed the waiting label Feb 20, 2026
@svlandeg
Copy link
Member

Friendly reminder about this pull request! Let me know if there are any further updates needed.

There are unresolved conflicts and in February 2025 you said you would look into the tests and the coverage. The CI has been red and has been waiting for action from you since (cf conversation ☝️ )

@iloveitaly
Copy link
Author

@svlandeg ah, right! I'll fix that up.

@github-actions github-actions bot removed the waiting label Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts Automatically generated when a PR has a merge conflict feature New feature or request waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add comments on tables and columns, visible also on the generated DB

3 participants