👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs#1276
👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs#1276ryangalamb wants to merge 1 commit intofastapi:mainfrom
Conversation
ryangalamb
changed the title
|
Currently most pulls fail tests due to this issue with 3.7 |
|
@ryangalamb Would it be possible to merge this, so #1226 can be unblocked? |
|
I don't have the ability to merge. @tiangolo when you get a chance, could you please take a look at this? All CI pipelines are failing without this fix 🙏 |
There was a problem hiding this comment.
Hi @ryangalamb,
I totally missed this PR, sorry!
I've actually been wanting to upgrade the test suite further to also test on different OS's, see #1290. Only I've been running into time-out issues with smokeshow 😭
But I'm looking into this and will sort things out. In the meantime, testing on Python 3.7 has been temporarily disabled.
This PR would have definitely been a good quick fix though, I'm sorry I didn't see it sooner. Thanks for contributing! Really appreciate it. I'll go ahead and close this now, but I'll continue working on getting the CI in a proper state again.
In the meantime, at least other PRs should go greeen again with 3.7 temporarily disabled (though admittedly not ideal).
|
Now fixed with #1309 |
5 participants
More info in this thread: actions/setup-python#962
Announcement for moving
ubuntu-latestto 24.04: actions/runner-images#10636It says that the setup-python action should be able to install 3.7, but the discussion in actions/setup-python#962 (and the failing pipelines in this repo) say otherwise.