🐛 Fix path parameters being replaced by same-named local variables#79
Merged
savannahostrowski merged 3 commits intomainfrom Feb 25, 2026
Merged
🐛 Fix path parameters being replaced by same-named local variables#79savannahostrowski merged 3 commits intomainfrom
savannahostrowski merged 3 commits intomainfrom
Conversation
savannahostrowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #66, I made it so that we resolve the AST and grab any string variables that may be used in path definitions (see #49). However, this wasn't scoped tightly enough as variables assigned inside functions, classes, and lambdas could inadvertently replace path parameters of the same name (e.g. integration = "redis" inside a handler replacing {integration} in the route path). This fix uses an intermediate representation with sentinel values (\uE000) to differentiate between path parameters in string literals and bare name identifier references, so only the latter are ever substituted.