Open
Conversation
(1) Breaking change added super().__init__() to DDPMCB so that self.n_inp in TrainCB gets initialized (TrainCB changed after the lesson and this change makes DDPMCB consistent with the new version of TrainCB) (2) Non-breaking change deleted reference to global variable 'learn' because 'model' is already being passed to the method as a parameter, so, no need to refer to the global model
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) Breaking change
added super().init() to DDPMCB so that self.n_inp in TrainCB gets initialized (TrainCB changed after the lesson and this change makes DDPMCB consistent with the new version of TrainCB)
(2) Non-breaking change
deleted reference to global variable 'learn' because 'model' is already being passed to the method as a parameter, so, no need to refer to the global model