Add scroll wheel support for font size adjustment#56
Open
ishanhemnani wants to merge 2 commits intofarzaa:mainfrom
Open
Add scroll wheel support for font size adjustment#56ishanhemnani wants to merge 2 commits intofarzaa:mainfrom
ishanhemnani wants to merge 2 commits intofarzaa:mainfrom
Conversation
chtnnh
suggested changes
Apr 15, 2025
chtnnh
left a comment
chtnnh
left a comment
There was a problem hiding this comment.
have tested the functionality, works great!
minor comments, when you resolve these, this pr is good to merge
freewrite/ContentView.swift
Outdated
| NSHapticFeedbackManager.defaultPerformer.perform(.generic, performanceTime: .now) | ||
| let direction = -scrollBuffer > 0 ? 2 : -2 | ||
| let newSize = fontSize + CGFloat(direction) | ||
| fontSize = min(max(newSize, 12), 32) // Limit font size between 12 and 32 |
There was a problem hiding this comment.
limit the font size between 16 and 26 (that's the limit in the original app)
freewrite.xcodeproj/project.pbxproj
Outdated
| CURRENT_PROJECT_VERSION = 1; | ||
| DEVELOPMENT_ASSET_PATHS = "\"freewrite/Preview Content\""; | ||
| DEVELOPMENT_TEAM = 2UDAY4J48G; | ||
| DEVELOPMENT_TEAM = 4YS2543B33; |
There was a problem hiding this comment.
don't commit this, this will affect development for all contributors
Author
|
changed to the development team to as it was and changer the limit (16 - 26) |
chtnnh
approved these changes
Apr 17, 2025
chtnnh
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the scroll functionality to the font size, now you can hover and swipe with 2 fingers to change the font size.
I am new to xcode or swift development so pardon me if the development team line wasn't to be changed as it was the only way to run freewrite locally.