Skip to content

Fix cursor overlay invisible on secondary monitors #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Catafal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix cursor overlay invisible on secondary monitors #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion leanring-buddy/OverlayWindow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,12 @@ class OverlayWindowManager {
)

let hostingView = NSHostingView(rootView: contentView)
hostingView.frame = screen.frame
// Use window-local coordinates (origin .zero), not global screen coordinates.
// The NSPanel is already positioned at screen.frame.origin via OverlayWindow.init.
// NSView.frame is relative to the window's content area, which always starts at (0,0).
// Using screen.frame here (with non-zero origin on secondary monitors) would offset
// the hosting view outside the window bounds, making the overlay invisible.
hostingView.frame = CGRect(origin: .zero, size: screen.frame.size)
window.contentView = hostingView

overlayWindows.append(window)
Expand Down