Fix blank Settings window with menu bar redirect#20
Open
mvanhorn wants to merge 1 commit intofarzaa:mainfrom
Open
Fix blank Settings window with menu bar redirect#20mvanhorn wants to merge 1 commit intofarzaa:mainfrom
mvanhorn wants to merge 1 commit intofarzaa:mainfrom
Conversation
The Settings scene used EmptyView() which left users with a blank window when pressing Cmd+,. Replace with a small view that explains the app lives in the menu bar. Fixes farzaa#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings scene used
EmptyView()to satisfy SwiftUI's one-scene requirement. But pressing Cmd+, still opens it, leaving users with a blank window (#12).Replaced with a small view that says "Clicky lives in your menu bar" and points users to the menu bar icon. Uses system SF Symbol and standard secondary text colors.
Single file changed, 15 lines added. No new dependencies, no behavior changes outside the Settings window.
Fixes #12
This contribution was developed with AI assistance (Claude Code).