Added catch to 0*inf and fixed a bug with sampling mpisndot#1
Open
jacobgolomb wants to merge 6 commits intofarr:will-changesfrom
Open
Added catch to 0*inf and fixed a bug with sampling mpisndot#1jacobgolomb wants to merge 6 commits intofarr:will-changesfrom
jacobgolomb wants to merge 6 commits intofarr:will-changesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numpyro was getting mad about sometimes being able to multiply 0*inf in the 2d interp function so I added an explicit catch to change 0 to a finite number if it is about to be multiply by -inf.
Also mpisndot was not being correctly sampled so I fixed a typo and made sure the
evolve_parameters()function also returns the value of mpisndot.Also there is a weird peak that forms in very low values of fpl (I should check to make sure this is due to something like low N_eff here) so I set the lower bound of fpl to be 0.01 (which I think is a reasonable choice).