Implement store and load for wrapped types (for Hive & Iceberg)#4
Draft
Implement store and load for wrapped types (for Hive & Iceberg)#4
Conversation
Co-Authored-By: Eric Kidd <36963+emk@users.noreply.github.com>
This turned out to be surprisingly tricky. The key insight is that LOAD and STORE aren't really symmetrical, at least not in this version of the code. Instead, %STORE(expr) gets manually inserted as a phantom operator, but %LOAD(var_ref) only occurs as part of a variable reference. This means that transforms, `sql_quote!` and all our other rewriting machinery don't even notice that LOADs exist. This is a weird decision, and it might not be optimal in the long run, but it works. This brings us down to `7 tests failed, 64 passed, 3 pending`, and all the failing test cases are places we need to expand SELECT wildcards like `*`, `table.*`, etc., into column lists with explicit STORE operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the work-in-progress for Hive support using the
dbcrossbar_trinocrate. It was a joint project by @hanakslr and me.I fixed a few more issues this weekend!
This currently only fails 7 tests, all related to
SELECTwildcards in some way. So we're only missing one final fix.@hanakslr, this was a fun challenge, and I enjoyed working on it!
Current Hive test status
CC @dave-shirley-faraday @seamusabshere