Skip to content

Fix colspan cells producing misaligned markdown table columns #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fantomc0der merged 1 commit into from
Apr 27, 2026
Merged

Fix colspan cells producing misaligned markdown table columns #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/converters/html-to-markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ function createTurndownService(): TurndownService {
const text = content.replace(/[\r\n]+/g, " ").replace(/\|/g, "\\|").trim();
const index = directCellIndex(node);
const prefix = index === 0 ? "| " : " ";
return prefix + text + " |";
const rawSpan = parseInt((node as HTMLElement).getAttribute?.("colspan") ?? "1", 10);
const span = Number.isFinite(rawSpan) && rawSpan > 1 ? rawSpan : 1;
const extra = span > 1 ? " |".repeat(span - 1) : "";
return prefix + text + " |" + extra;
},
});

Expand Down
6 changes: 3 additions & 3 deletions tests/converters/html-to-markdown.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,15 +288,15 @@ describe("htmlToMarkdown", () => {
expect(result).toContain("| Magic Number | 17 |");
});

it("separator column count respects colspan on first-row cells", () => {
it("colspan cells emit extra empty columns to keep table width consistent", () => {
const html = `
<table>
<tr><td colspan="2">Header</td></tr>
<tr><td>Left</td><td>Right</td></tr>
</table>
`;
const result = htmlToMarkdown(html);
expect(result).toContain("| Header |");
expect(result).toContain("| Header | |");
expect(result).toContain("| --- | --- |");
expect(result).toContain("| Left | Right |");
});
Expand Down Expand Up @@ -351,7 +351,7 @@ describe("htmlToMarkdown", () => {
</div>
`;
const result = htmlToMarkdown(html);
expect(result).toContain("| someuser |");
expect(result).toContain("| someuser | |");
expect(result).toContain("| --- | --- |");
expect(result).toContain("| Magic Number | 17 |");
expect(result).toContain("| Job | Celebrity Nobody |");
Expand Down
Loading