Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes issues in the Telegram Bridge's JSON serialization for a text-or-number value converter, ensuring that JSON write operations do not throw errors unexpectedly.
- Use a Sequence for collecting key/value pairs before freezing into a dictionary
- Update error messages and improve method signatures for better clarity
- Refactor the TextOrNumberValue struct by renaming internal fields and updating annotations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/Falko.Talkie.Bridges.Telegram/Serialization/TextOrNumberValueDictionaryConverter.cs | Refactored JSON read/write operations; replaced Dictionary with Sequence; updated error messages and formatting |
| Sources/Falko.Talkie.Bridges.Telegram/Models/TextOrNumberValue.cs | Renamed internal fields and updated annotations; changed ToString() to return a constant string |
Comments suppressed due to low confidence (1)
Sources/Falko.Talkie.Bridges.Telegram/Serialization/TextOrNumberValueDictionaryConverter.cs:81
- [nitpick] Consider revising this error message to clearly indicate the problem, for example: "Value for key '{pair.Key}' does not contain a valid number or text."
throw new JsonException($"Value for key '{pair.Key}' does not contain a number or text, or empty.");
Sources/Falko.Talkie.Bridges.Telegram/Serialization/TextOrNumberValueDictionaryConverter.cs
Outdated
Show resolved
Hide resolved
…throw-json-error-on-json-write-operations Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dc27a34 to
61572cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.