Skip to content

Conversation

@sgaist
Copy link

@sgaist sgaist commented Nov 7, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

This PR adds pre-commit hooks to keep files clean (e.g. no trailing white spaces, etc.)

It also applies the hooks on the repo

Which issue(s) this PR fixes:

Fixes falcosecurity/falco#3727

Special notes for your reviewer:

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@poiana
Copy link

poiana commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sgaist
Once this PR has been reviewed and has the lgtm label, please assign jasondellaluce for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from Kaizhe and darryk10 November 7, 2025 12:56
@poiana poiana added the size/XXL label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Rules files suggestions

falco_rules.yaml

Comparing 2a9ef9c65336be314043d5aef6630c1e4eab56dc with latest tag falco-rules-5.0.0

No changes detected

falco-sandbox_rules.yaml

Comparing 2a9ef9c65336be314043d5aef6630c1e4eab56dc with latest tag falco-sandbox-rules-6.0.0

No changes detected

falco-incubating_rules.yaml

Comparing 2a9ef9c65336be314043d5aef6630c1e4eab56dc with latest tag falco-incubating-rules-6.0.0

No changes detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Spaces should be trimmed from end of lines in rules file

2 participants