Skip to content

Fix non-localized company suffixes in CH and it locales #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huerlisi wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −5
Open

Fix non-localized company suffixes in CH and it locales #3271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/locales/de-CH.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3251,8 +3251,6 @@ de-CH:
- und Partner
- "& Co."
- Gruppe
- LLC
- Inc.
legal_form:
- GmbH
- AG
Expand Down
4 changes: 2 additions & 2 deletions lib/locales/fr-CH.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,13 @@ fr-CH:
- CH
company:
suffix:
- SA
- Sàrl
- AG
- GmbH
- et associés
- "& Co."
- Groupe
- LLC
- Inc.
name:
- "#{Name.last_name} #{suffix}"
- "#{Name.last_name}-#{Name.last_name}"
Expand Down
2 changes: 1 addition & 1 deletion lib/locales/it.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ it:
suffix:
- SPA
- e figli
- Group
- Gruppo
- s.r.l.
buzzwords:
-
Expand Down
7 changes: 7 additions & 0 deletions test/test_de_ch_locale.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ def test_de_ch_company_methods
assert_kind_of String, Faker::Company.name
end

def test_de_ch_company_suffix_has_no_english_forms
suffixes = I18n.translate('faker.company.suffix', locale: :'de-CH')

assert_not_includes suffixes, 'LLC'
assert_not_includes suffixes, 'Inc.'
end

def test_de_ch_internet_methods
assert_kind_of String, Faker::Internet.domain_suffix
end
Expand Down
9 changes: 9 additions & 0 deletions test/test_fr_ch_locale.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ def test_fr_ch_company_methods
assert_kind_of String, Faker::Company.name
end

def test_fr_ch_company_suffix_uses_swiss_forms
suffixes = I18n.translate('faker.company.suffix', locale: :'fr-CH')

assert_includes suffixes, 'SA'
assert_includes suffixes, 'Sàrl'
assert_not_includes suffixes, 'LLC'
assert_not_includes suffixes, 'Inc.'
end

def test_fr_ch_internet_methods
assert_kind_of String, Faker::Internet.email
assert_kind_of String, Faker::Internet.domain_suffix
Expand Down
7 changes: 7 additions & 0 deletions test/test_it_locale.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ def test_it_company_methods
assert_kind_of String, Faker::Company.name
end

def test_it_company_suffix_has_no_english_forms
suffixes = I18n.translate('faker.company.suffix', locale: :it)

assert_includes suffixes, 'Gruppo'
assert_not_includes suffixes, 'Group'
end

def test_it_internet_methods
assert_kind_of String, Faker::Internet.email
assert_kind_of String, Faker::Internet.domain_suffix
Expand Down