Account for package metadata that doesn't include filename when deriving hashed filename

[kasparsd]

Fixes #492.

Updated get_hashed_filename() method to build a stable, hashed install path for a FAIR package from its metadata.

It works in this order:

1. It derives a short DID hash from the package ID.
2. It tries to split filename into two parts: a slug-like directory name and a plugin file name.
3. If the filename does not provide a slug, it falls back to the metadata slug.
4. If the filename does not provide a file portion, it assumes the main plugin file should be slug.php.
5. It appends the DID hash to the slug unless it is already present.
6. If the package type is wp-plugin, it returns a WordPress-style plugin path in the form slug-didhash/file.php.
7. For non-plugin types, it returns only the hashed slug.

The intent of this version is:

• prefer the slug embedded in filename when available
• gracefully recover when filename is missing or incomplete
• avoid double-appending the DID hash
• return plugin paths as directory/file.php
• return non-plugin paths as just the hashed directory/slug name

Examples for this implementation:

• plugin with filename = example/example.php returns example-<hash>/example.php
• plugin with missing filename falls back to example-<hash>/example.php
• theme with slug example returns example-<hash>

[github-actions]

🧪 Test this PR on Playground

[costdev]

Thanks for the changes @kasparsd! I won't get to test this or do a full review, but hopefully someone has availability and can help determine if any further tests would be good here.

[kasparsd]

All the code review feedback has been addressed. Added a few additional phpunit test cases to account for the edge cases resolved.

[costdev]

@cdils I won't get to do a full review of this PR. If someone else if available to do a full review, that would be great!

Edit: It looks like @afragen started a review

Changes made

[cdils]

@costdev sorry–I didn't mean to trigger a review from you as I saw your earlier comment. I was attempting to get rid of resolved conversations pertaining to the previous review. Blame it on my github skillz. :)

[costdev]

No worries haha!

[afragen]

Is there a test for the current state of the FAIR Connect where fair-plugin/plugin.php doesn’t list a filename in the metadata?

[kasparsd]

@afragen Yes, this pull request adds those test cases, including this one with the missing filename:

https://github.com/kasparsd/fair-plugin/blob/a29caf53ec45d65666c92c8b78edaf41860228f6/tests/phpunit/tests/Packages/GetHashedFilenameTest.php#L34-L47

My proposal is to remove the filename requirement eventually since they're not really required as WP resolves the plugin file automatically by scanning all root-level PHP files for the Plugin Name header during install/activation. Created #500 to demonstrate that. But that's for a separate discussion.

[cdils]

@kasparsd Can you update status on readiness to merge this PR? It looks like it needs to be rebased against release_1.4.1 but not sure beyond that.

[kasparsd]

@cdils This is ready for merge, and it appears to be targeting fairpm:release_1.4.1 already.