Skip to content

Breadcrumbs issue fixed #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pallavimshr wants to merge 2 commits into
base: feat/zitadel
Choose a base branch
from
Open

Breadcrumbs issue fixed #980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63059c7
Breadcrumbs issue fixed
Aug 28, 2024
f834c4e
minor update
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions studio/src/components/PageHeader/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ function Pageheader() {
: pathSnippets[0];

const isBreadCrumbsHidden =
(pathSnippets.includes('edit') || pathSnippets.includes('create')) &&
(entity === 'posts' || entity === 'pages' || entity === 'fact-checks'); // redundant entity check for fact-checks?
(pathSnippets.includes('edit') || pathSnippets.includes('create')) &&
['posts', 'pages', 'fact-checks'].includes(entity);
const breadcrumbItems = useMemo(() => {
const urlBreadcrumbItems = pathSnippets.map((empty, index) => {
const url = `/${pathSnippets.slice(0, index + 1).join('/')}`;
Expand Down Expand Up @@ -78,8 +78,8 @@ function Pageheader() {
}
});
return _.filter(urlBreadcrumbItems);

}, [pathSnippets, location.pathname]);

const handleOnBack = () => {
if (isBreadCrumbsHidden) {
if (
Expand All @@ -106,19 +106,21 @@ function Pageheader() {
}
};
const itemRender = (route, params, routes, paths) => {

const breadcrumbItem = breadcrumbItems.find(item => item.path === route.path);
const last = routes.indexOf(route) === routes.length - 1;
if (last && routes.length > 1) {
if (last) {
return (
!isBreadCrumbsHidden && (
<h2 style={{ display: 'inline', color: '#000000d9' }}>{route.breadcrumbName}</h2>
<h2 style={{ display: 'inline', color: '#000000d9' }}>{breadcrumbItem?.breadcrumbName}</h2>
)
);
}
return (
!isBreadCrumbsHidden && (
<h2 style={{ display: 'inline' }}>
<Link style={routes.length === 1 ? { color: '#000000d9' } : null} to={route.path}>
{route.breadcrumbName}
{breadcrumbItem?.breadcrumbName}
</Link>
</h2>
)
Expand All @@ -130,6 +132,7 @@ function Pageheader() {
['members', 'advanced', 'website', 'admin'].includes(entity) ||
location.pathname.split('/').pop() === 'create'
)

return (
<AntPageHeader
backIcon={isBreadCrumbsHidden ? <LeftOutlined /> : null}
Expand Down