chore: Maintenance updates #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
Comments suppressed due to low confidence (3)
main.py:12
- The call to file.close() is redundant when using the 'with open' statement. It can be removed.
file.close()
README.md:4
- The word 'finanical' should be 'financial'.
A beginner's guide to setting up and using the [Stock Indicators for Python](https://python.stockindicators.dev) library for financial market analysis.
README.md:199
- [nitpick] The date 'January 2025' should be 'January 2024' for consistency with the rest of the document.
-- @DaveSkender, January 2025
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (4)
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
Comments suppressed due to low confidence (2)
main.py:1
- [nitpick] The comment style on this line is inconsistent with the rest of the comments. Consider using a consistent comment style throughout the code.
"""Hello indicators!""" # calculate a Simple Moving Average (SMA)
.github/workflows/lint-code.yml:10
- The removal of Python 3.9 from the test matrix might be unintentional. Ensure that dropping support for Python 3.9 is intended.
python-version: ["3.8", "3.10", "3.12"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick refresh on this content