Skip to content

fix: use Attribute::decode_and_unescape_value instead of unescape_value#40

Merged
fasterthanlime merged 1 commit intofacet-rs:mainfrom
Erik1000:fix/unescape_value
Apr 6, 2026
Merged

fix: use Attribute::decode_and_unescape_value instead of unescape_value#40
fasterthanlime merged 1 commit intofacet-rs:mainfrom
Erik1000:fix/unescape_value

Conversation

@Erik1000
Copy link
Copy Markdown
Contributor

I got a bit of a déjà vu on this one

@Erik1000
Copy link
Copy Markdown
Contributor Author

Erik1000 commented Mar 19, 2026

Background is that https://docs.rs/quick-xml/latest/quick_xml/events/attributes/struct.Attribute.html#method.unescape_value is unavailable if encoding feature of quick-xml is active. for me thats because i use calamine
docs suggest to only use unescape_value in applications

@fasterthanlime fasterthanlime added this pull request to the merge queue Apr 6, 2026
Merged via the queue into facet-rs:main with commit d8a0e2a Apr 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants