Update torchmultimodal test golden values after trunc_normal_ change#539
Closed
albanD wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Update torchmultimodal test golden values after trunc_normal_ change#539albanD wants to merge 1 commit intofacebookresearch:mainfrom
albanD wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: D94908913 changed `torch.nn.init.trunc_normal_` from erfinv-based to rejection-sampling, which produces different numerical outputs with the same seed. This updates the hardcoded golden values in torchmultimodal tests to match the new implementation. Updated tests: - test_albef.py: image_embeddings, image_embeddings_momentum, multimodal_embeddings, multimodal_embeddings_momentum - test_image_encoder.py: test_vision_transformer - test_omnivore.py: swin_t, swin_s, swin_b forward tests - test_swin_transformer_3d_encoder.py: test_swin_transformer_3d_encoder - test_vision_transformer.py: test_vision_transformer_patch_drop Partial fix for T258469553 Differential Revision: D95591588
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D94908913 changed
torch.nn.init.trunc_normal_from erfinv-basedto rejection-sampling, which produces different numerical outputs
with the same seed. This updates the hardcoded golden values in
torchmultimodal tests to match the new implementation.
Updated tests:
multimodal_embeddings, multimodal_embeddings_momentum
Partial fix for T258469553
Differential Revision: D95591588