Remove head_mask and attention weights from VideoGPT#536
Open
stashuk-olek wants to merge 2 commits intofacebookresearch:mainfrom
Open
Remove head_mask and attention weights from VideoGPT#536stashuk-olek wants to merge 2 commits intofacebookresearch:mainfrom
stashuk-olek wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@stashuk-olek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92927089. |
stashuk-olek
added a commit
to stashuk-olek/multimodal
that referenced
this pull request
Feb 11, 2026
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. This removes: - `attention_weights` field from `TransformerDecoderOutput` and `TransformerLayerOutput` NamedTuples - `head_mask` and `return_attn_weights` params from `MultimodalGPT`, `MultimodalTransformerDecoder`, `TransformerDecoder`, and `TransformerDecoderLayer` - `head_mask` param from `AxialAttention.forward` in video_vqvae.py - `return_attn_weights` param from `GenerationUtil.sample` - All `head_mask` and `return_attn_weights` usage from tests Differential Revision: D92927089
stashuk-olek
force-pushed
the
export-D92927089
branch
from
371945b to
79d87de
Compare
|
@stashuk-olek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92927089. |
stashuk-olek
added a commit
to stashuk-olek/multimodal
that referenced
this pull request
Feb 12, 2026
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. Differential Revision: D92927089
stashuk-olek
added a commit
to stashuk-olek/multimodal
that referenced
this pull request
Feb 13, 2026
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. Reviewed By: OmarPavel Differential Revision: D92927089
stashuk-olek
added a commit
to stashuk-olek/multimodal
that referenced
this pull request
Feb 13, 2026
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. Reviewed By: OmarPavel Differential Revision: D92927089
stashuk-olek
added a commit
to stashuk-olek/multimodal
that referenced
this pull request
Feb 13, 2026
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. Reviewed By: OmarPavel Differential Revision: D92927089
stashuk-olek
added a commit
to stashuk-olek/multimodal
that referenced
this pull request
Feb 13, 2026
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. Reviewed By: OmarPavel Differential Revision: D92927089
stashuk-olek
added a commit
to stashuk-olek/multimodal
that referenced
this pull request
Feb 13, 2026
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. Reviewed By: OmarPavel Differential Revision: D92927089
… weights in FLAVA (facebookresearch#535) Summary: The `attentions` field on `TransformerOutput` and `return_attn_weights`/`head_mask` parameters in the FLAVA encoder stack were never used by any consumer. This diffs cleans it up. Later the intent is to simplify attention usage / use common API for them. Reviewed By: OmarPavel Differential Revision: D92927086
…h#536) Summary: Remove dead `head_mask`, `return_attn_weights`, and `attention_weights` from the VideoGPT stack. These features were never used by any consumer — `head_mask` was always `None` or all-ones, and `return_attn_weights` was always `False` except in tests that verified the feature itself. Reviewed By: OmarPavel Differential Revision: D92927089
stashuk-olek
force-pushed
the
export-D92927089
branch
from
79d87de to
92fdefc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove dead
head_mask,return_attn_weights, andattention_weightsfrom the VideoGPT stack. These features were never used by any consumer —head_maskwas alwaysNoneor all-ones, andreturn_attn_weightswas alwaysFalseexcept in tests that verified the feature itself.This removes:
attention_weightsfield fromTransformerDecoderOutputandTransformerLayerOutputNamedTupleshead_maskandreturn_attn_weightsparams fromMultimodalGPT,MultimodalTransformerDecoder,TransformerDecoder, andTransformerDecoderLayerhead_maskparam fromAxialAttention.forwardin video_vqvae.pyreturn_attn_weightsparam fromGenerationUtil.samplehead_maskandreturn_attn_weightsusage from testsDifferential Revision: D92927089