Use scaled_dot_product_attention_with_weights utility#534
Open
stashuk-olek wants to merge 1 commit intofacebookresearch:mainfrom
Open
Use scaled_dot_product_attention_with_weights utility#534stashuk-olek wants to merge 1 commit intofacebookresearch:mainfrom
stashuk-olek wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: We have multiple implementations of attention in our codebase, making it hard to migrate between different hardware, pick up SOTA etc. This diff migrates torchmultimodal for the exact same implementation from SDPA. More details can be found here https://docs.google.com/document/d/1XCZkhLtBNXGhxoYZ2-47XVvH7bQDOzPXBNZyL7Q7Fqo/edit?tab=t.0#heading=h.gzjhznhk1ejy Differential Revision: D92574396
meta-cla
bot
added
the
CLA Signed
|
@stashuk-olek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92574396. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We have multiple implementations of attention in our codebase, making it hard to migrate between different hardware, pick up SOTA etc. This diff migrates torchmultimodal for the exact same implementation from SDPA. More details can be found here https://docs.google.com/document/d/1XCZkhLtBNXGhxoYZ2-47XVvH7bQDOzPXBNZyL7Q7Fqo/edit?tab=t.0#heading=h.gzjhznhk1ejy
Differential Revision: D92574396