Fix AC order for FLAVA example#434
Fix AC order for FLAVA example#434rohan-varma wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
Summary: ShardedGradScaler not needed for bf16 training. Differential Revision: D47218367 fbshipit-source-id: 143269cc8dc05805b3caebe73035ce0f39c7e8d4
Summary: There have been some fixes to the non-reentrant AC and FLAVA model now works with it. Differential Revision: D47218368 fbshipit-source-id: 448969eb42e6df224dcd7ea82b4fabe63dcecf96
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47218368 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 68.61% 68.63% +0.01%
==========================================
Files 169 169
Lines 11338 11336 -2
==========================================
Hits 7780 7780
+ Misses 3558 3556 -2
☔ View full report in Codecov by Sentry. |
ankitade
left a comment
ankitade
left a comment
There was a problem hiding this comment.
please update the test plan with a cmd you ran
|
Hi @rohan-varma! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
4 participants
Summary: There have been some fixes to the non-reentrant AC and FLAVA model now works with it.
Differential Revision: D47218368