Skip to content

Upstream TorchSim Interface to prevent CI issues and slippage with fa…#1895

Merged
lbluque merged 3 commits intomainfrom
torch-sim
Mar 13, 2026
Merged

Upstream TorchSim Interface to prevent CI issues and slippage with fa…#1895
lbluque merged 3 commits intomainfrom
torch-sim

Conversation

@lbluque
Copy link
Copy Markdown
Contributor

@lbluque lbluque commented Mar 12, 2026

@meta-cla meta-cla Bot added the cla signed label Mar 12, 2026
@lbluque lbluque added the enhancement New feature or request label Mar 12, 2026
@lbluque lbluque requested review from mshuaibii and rayg1234 and removed request for mshuaibii March 12, 2026 21:21
Comment thread src/fairchem/core/calculate/torchsim_interface.py
Comment thread tests/core/calculate/test_torchsim_interface.py Outdated
mshuaibii
mshuaibii previously approved these changes Mar 12, 2026
Copy link
Copy Markdown
Contributor

@mshuaibii mshuaibii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this is all they need

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 88.23529% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.61%. Comparing base (6373a48) to head (8cc4e37).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/fairchem/core/calculate/torchsim_interface.py 88.23% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
- Coverage   66.67%   66.61%   -0.07%     
==========================================
  Files         167      176       +9     
  Lines       14278    14556     +278     
==========================================
+ Hits         9520     9696     +176     
- Misses       4758     4860     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbluque lbluque requested a review from mshuaibii March 12, 2026 22:19
@mshuaibii mshuaibii added the minor Minor version release label Mar 12, 2026
@lbluque lbluque enabled auto-merge March 13, 2026 00:30
@lbluque lbluque added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit ebf84a4 Mar 13, 2026
19 checks passed
@lbluque lbluque deleted the torch-sim branch March 13, 2026 01:09
@CompRhys
Copy link
Copy Markdown
Contributor

TorchSim/torch-sim#499 making the install on the CI testing on our side point to fairchem = ["fairchem-core @ git+https://github.com/facebookresearch/fairchem.git@main#subdirectory=packages/fairchem-core"] gives errors as triton isn't installed. I cannot see triton in the deps anywhere in the package is that an oversight or is there something wrong with this way of git installing fairchem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed enhancement New feature or request minor Minor version release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants