Fix(eval): evaluate in :task_cleanroom images#42
Merged
Conversation
Submissions are now evaluated in the artifact-free cleanroom image by default instead of the full :task build environment, so a submission can't rely on build artifacts leaked into :task. --image-tag stays as an explicit override (pass --image-tag task for the full build env). This avoids drifts between the inference image and evaluation image. Internal-reference: fdbd6657
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes ProgramBench evaluation to run submissions in the artifact-free :task_cleanroom Docker image by default, aligning evaluation with inference and preventing reliance on leaked build artifacts. It keeps --image-tag as an explicit override to use the full :task environment when desired.
Changes:
- Switch default
image_tagfromtasktotask_cleanroomin the core evaluator (eval.py) and batch evaluator (eval_batch.py). - Update the CLI
programbench evaldefault--image-tagtotask_cleanroom. - Expand CLI help text to explain why
task_cleanroomis the default and how to override back totask.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/programbench/eval/eval.py |
Updates the evaluator’s default Docker image tag to task_cleanroom. |
src/programbench/eval/eval_batch.py |
Updates batch evaluation defaults to use task_cleanroom unless overridden. |
src/programbench/cli/main.py |
Updates CLI default and help text for --image-tag to default to task_cleanroom. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submissions are now evaluated in the artifact-free cleanroom image by default instead of the full :task build environment, so a submission can't rely on build artifacts leaked into :task. --image-tag stays as an explicit override (pass --image-tag task for the full build env).
This avoids drifts between the inference image and evaluation image.
Internal-reference: fdbd6657
Closes #9