let ThreadPoolExecutor observer callbacks be noexcept#530
Closed
let ThreadPoolExecutor observer callbacks be noexcept#530
Conversation
Summary: If observer callbacks were permitted to fail, then the behavior being observed would have to handle that failure. But that can get complicated. Easier to require observer callbacks not to fail. Reviewed By: iahs, ot Differential Revision: D96358302
meta-cla
bot
added
the
CLA Signed
|
@yfeldblum has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96358302. |
meta-codesync bot
pushed a commit
to facebook/folly
that referenced
this pull request
Mar 19, 2026
Summary: X-link: facebookresearch/DCPerf#530 If observer callbacks were permitted to fail, then the behavior being observed would have to handle that failure. But that can get complicated. Easier to require observer callbacks not to fail. Reviewed By: iahs, ot Differential Revision: D96358302 fbshipit-source-id: e1211349a62c4a133b2410f5489c4d6b2a895c51
meta-codesync bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Mar 19, 2026
Summary: X-link: facebookresearch/DCPerf#530 If observer callbacks were permitted to fail, then the behavior being observed would have to handle that failure. But that can get complicated. Easier to require observer callbacks not to fail. Reviewed By: iahs, ot Differential Revision: D96358302 fbshipit-source-id: e1211349a62c4a133b2410f5489c4d6b2a895c51
meta-codesync bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Mar 19, 2026
Summary: X-link: facebookresearch/DCPerf#530 If observer callbacks were permitted to fail, then the behavior being observed would have to handle that failure. But that can get complicated. Easier to require observer callbacks not to fail. Reviewed By: iahs, ot Differential Revision: D96358302 fbshipit-source-id: e1211349a62c4a133b2410f5489c4d6b2a895c51
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Summary: Pull Request resolved: #530 If observer callbacks were permitted to fail, then the behavior being observed would have to handle that failure. But that can get complicated. Easier to require observer callbacks not to fail. Reviewed By: iahs, ot Differential Revision: D96358302 fbshipit-source-id: e1211349a62c4a133b2410f5489c4d6b2a895c51
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 24, 2026
Summary: X-link: facebookresearch/DCPerf#530 If observer callbacks were permitted to fail, then the behavior being observed would have to handle that failure. But that can get complicated. Easier to require observer callbacks not to fail. Reviewed By: iahs, ot Differential Revision: D96358302 fbshipit-source-id: e1211349a62c4a133b2410f5489c4d6b2a895c51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: If observer callbacks were permitted to fail, then the behavior being observed would have to handle that failure. But that can get complicated. Easier to require observer callbacks not to fail.
Reviewed By: iahs, ot
Differential Revision: D96358302