Add FBPower monitor class and read_sensors#499
Open
lrh12580 wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Add FBPower monitor class and read_sensors#499lrh12580 wants to merge 1 commit intofacebookresearch:v2-betafrom
lrh12580 wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
meta-cla
bot
added
the
CLA Signed
Summary:
The diff stack enables power-telemetry tracing for Benchpress plugins and supports the following platforms: **T1_CPL, T1_MLN, T1_BGM, T1_TRN, and T11_GRC_ARM**.
- **Task:** T248954685
- **Claude CLI prompts:**
- `design.md` (P2203208599)
- `implementation.md` (P2203210057)
- **Related older diffs:**
- D73953894
- D92542871
### FBPower Monitor Class and `read_sensors`
- **Added FBPower monitor class** to **monitor power sensors**
- Files:
- `fbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf.py`
- `fbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf_monitors/fb_power/__init__.py`
- `fbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf_monitors/fb_power/monitor.py`
- **Updated BUCK build** to include the **additional targets** required by the new monitor components.
Differential Revision: D94542928
lrh12580
force-pushed
the
export-D94542928-to-v2-beta
branch
from
1889e06 to
7a99486
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
Summary: Pull Request resolved: #499 The diff stack enables power-telemetry tracing for Benchpress plugins and supports the following platforms: **T1_CPL, T1_MLN, T1_BGM, T1_TRN, and T11_GRC_ARM**. - **Task:** T248954685 - **Claude CLI prompts:** - `design.md` (P2203208599) - `implementation.md` (P2203210057) - **Related older diffs:** - D73953894 - D92542871 ### FBPower Monitor Class and `read_sensors` - **Added FBPower monitor class** to **monitor power sensors** - Files: - `fbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf.py` - `fbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf_monitors/fb_power/__init__.py` - `fbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf_monitors/fb_power/monitor.py` - **Updated BUCK build** to include the **additional targets** required by the new monitor components. Reviewed By: excelle08 Differential Revision: D94542928 fbshipit-source-id: 47f68ce1a38e0d4e39ff9f049d483e92f4d7b43d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The diff stack enables power-telemetry tracing for Benchpress plugins and supports the following platforms: T1_CPL, T1_MLN, T1_BGM, T1_TRN, and T11_GRC_ARM.
design.md(P2203208599)implementation.md(P2203210057)FBPower Monitor Class and
read_sensorsAdded FBPower monitor class to monitor power sensors
fbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf.pyfbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf_monitors/fb_power/__init__.pyfbcode/cea/chips/benchpress/benchpress/plugins/hooks/perf_monitors/fb_power/monitor.pyUpdated BUCK build to include the additional targets required by the new monitor components.
Differential Revision: D94542928