Move ucache_bench benchmark and job definitions from internal to main config files#490
Open
charles-typ wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Conversation
meta-cla
bot
added
the
CLA Signed
|
@charles-typ has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94889735. |
… config files (facebookresearch#490) Summary: This diff moves the ucache_bench benchmark and job definitions from the internal configuration files to the main public configuration files, as requested in T255377166. Changes made: 1. Added `ucache_bench` benchmark definition to `benchmarks.yml` with all associated metadata (parser, install/cleanup scripts, path, roles, tags, and metrics) 2. Added three ucache_bench job definitions to `jobs.yml`: - `ucache_bench_memory`: Memory-only cache benchmark using CacheLib - `ucache_bench_hybrid`: Hybrid RAM+SSD cache benchmark using CacheLib - `ucache_bench_custom`: Cache benchmark with custom parameters 3. Removed the corresponding entries from `benchmarks_internal.yml` and `jobs_internal.yml` This change makes the ucache_bench benchmark available for external use while maintaining all the same configuration options and parameters. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=ae7a6acb-3d89-4165-b854-6f411813ff89) Differential Revision: D94889735
charles-typ
force-pushed
the
export-D94889735-to-v2-beta
branch
from
974dca1 to
c9c817a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff moves the ucache_bench benchmark and job definitions from the internal configuration files to the main public configuration files, as requested in T255377166.
Changes made:
Added
ucache_benchbenchmark definition tobenchmarks.ymlwith all associated metadata (parser, install/cleanup scripts, path, roles, tags, and metrics)Added three ucache_bench job definitions to
jobs.yml:ucache_bench_memory: Memory-only cache benchmark using CacheLibucache_bench_hybrid: Hybrid RAM+SSD cache benchmark using CacheLibucache_bench_custom: Cache benchmark with custom parametersRemoved the corresponding entries from
benchmarks_internal.ymlandjobs_internal.ymlThis change makes the ucache_bench benchmark available for external use while maintaining all the same configuration options and parameters.
Session trajectory link
Differential Revision: D94889735