Add Ubuntu 24.04 support for WDL bench on ARM (G5)#437
Open
ahmadelyoussef wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Add Ubuntu 24.04 support for WDL bench on ARM (G5)#437ahmadelyoussef wants to merge 1 commit intofacebookresearch:v2-betafrom
ahmadelyoussef wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
|
@ahmadelyoussef has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92189863. |
) Summary: Ubuntu 24.04 ships with Python 3.12+ which enforces PEP 668 (externally managed environments) and Boost 1.83+ which uses CMake config mode instead of the legacy FindBoost module. These changes break the WDL benchmark installation on Ubuntu 24.04 ARM (G5 instances). This diff fixes the issues by: 1. Setting `PIP_BREAK_SYSTEM_PACKAGES=1` to allow pip installations without virtual environments on Python 3.12+ 2. Adding comprehensive Boost path detection logic that prioritizes system paths (`/usr/lib/aarch64-linux-gnu`) over `/usr/local` to avoid version mismatches from stale CMake config files 3. Passing explicit `Boost_INCLUDE_DIR` and `Boost_LIBRARY_DIR` to CMake via `--extra-cmake-defines` to fix builds with modern Boost (1.70+) 4. Setting `Boost_NO_BOOST_CMAKE=ON` to disable searching in `/usr/local` for mismatched CMake configs 5. Cleaning stale CMake cache and build directories before builds to avoid "missing library" errors from previous builds Differential Revision: D92189863
972d86a to
9a3414a
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Summary: Pull Request resolved: #437 Ubuntu 24.04 ships with Python 3.12+ which enforces PEP 668 (externally managed environments) and Boost 1.83+ which uses CMake config mode instead of the legacy FindBoost module. These changes break the WDL benchmark installation on Ubuntu 24.04 ARM (G5 instances). This diff fixes the issues by: 1. Setting `PIP_BREAK_SYSTEM_PACKAGES=1` to allow pip installations without virtual environments on Python 3.12+ 2. Adding comprehensive Boost path detection logic that prioritizes system paths (`/usr/lib/aarch64-linux-gnu`) over `/usr/local` to avoid version mismatches from stale CMake config files 3. Passing explicit `Boost_INCLUDE_DIR` and `Boost_LIBRARY_DIR` to CMake via `--extra-cmake-defines` to fix builds with modern Boost (1.70+) 4. Setting `Boost_NO_BOOST_CMAKE=ON` to disable searching in `/usr/local` for mismatched CMake configs 5. Cleaning stale CMake cache and build directories before builds to avoid "missing library" errors from previous builds Reviewed By: excelle08 Differential Revision: D92189863 fbshipit-source-id: d4553b98a4e3097473e067744694fd1c131f68ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Ubuntu 24.04 ships with Python 3.12+ which enforces PEP 668 (externally managed environments) and Boost 1.83+ which uses CMake config mode instead of the legacy FindBoost module. These changes break the WDL benchmark installation on Ubuntu 24.04 ARM (G5 instances).
This diff fixes the issues by:
PIP_BREAK_SYSTEM_PACKAGES=1to allow pip installations without virtual environments on Python 3.12+/usr/lib/aarch64-linux-gnu) over/usr/localto avoid version mismatches from stale CMake config filesBoost_INCLUDE_DIRandBoost_LIBRARY_DIRto CMake via--extra-cmake-definesto fix builds with modern Boost (1.70+)Boost_NO_BOOST_CMAKE=ONto disable searching in/usr/localfor mismatched CMake configsDifferential Revision: D92189863